Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 2174203002: OnDrawHardware() implementation with async messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/common/aw_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index 26065be6d52e98b6a046ff9f49b735197c1f46c7..300a5a156b8fc86282042fcad6c8b578d886f3d2 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -9,6 +9,7 @@
#include "android_webview/browser/browser_view_renderer_client.h"
#include "android_webview/browser/child_frame.h"
#include "android_webview/browser/compositor_frame_consumer.h"
+#include "android_webview/common/aw_switches.h"
#include "base/auto_reset.h"
#include "base/command_line.h"
#include "base/logging.h"
@@ -93,6 +94,8 @@ BrowserViewRenderer::BrowserViewRenderer(
const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner)
: client_(client),
ui_task_runner_(ui_task_runner),
+ async_on_draw_hardware_(base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAsyncOnDrawHardware)),
current_compositor_frame_consumer_(nullptr),
compositor_(nullptr),
is_paused_(false),
@@ -226,14 +229,13 @@ bool BrowserViewRenderer::OnDrawHardware() {
gfx::Transform transform_for_tile_priority =
external_draw_constraints_.transform;
- // If the WebView is on a layer, WebView does not know what transform is
- // applied onto the layer so global visible rect does not make sense here.
- // In this case, just use the surface rect for tiling.
- gfx::Rect viewport_rect_for_tile_priority;
+ gfx::Rect viewport_rect_for_tile_priority =
+ ComputeViewportRectForTilePriority();
- // Leave viewport_rect_for_tile_priority empty if offscreen_pre_raster_ is on.
- if (!offscreen_pre_raster_ && !external_draw_constraints_.is_layer) {
- viewport_rect_for_tile_priority = last_on_draw_global_visible_rect_;
+ if (async_on_draw_hardware_) {
+ compositor_->DemandDrawHwAsync(size_, viewport_rect_for_tile_priority,
+ transform_for_tile_priority);
+ return current_compositor_frame_consumer_->HasFrameOnUI();
}
content::SynchronousCompositor::Frame frame = compositor_->DemandDrawHw(
@@ -244,6 +246,21 @@ bool BrowserViewRenderer::OnDrawHardware() {
return current_compositor_frame_consumer_->HasFrameOnUI();
}
+ OnDrawHardwareProcessFrame(std::move(frame));
+ return true;
+}
+
+void BrowserViewRenderer::OnDrawHardwareProcessFrame(
+ content::SynchronousCompositor::Frame frame) {
+ TRACE_EVENT0("android_webview",
+ "BrowserViewRenderer::OnDrawHardwareProcessFrame");
+ if (!frame.frame)
+ return;
+
+ gfx::Transform transform_for_tile_priority =
+ external_draw_constraints_.transform;
+ gfx::Rect viewport_rect_for_tile_priority =
+ ComputeViewportRectForTilePriority();
std::unique_ptr<ChildFrame> child_frame = base::MakeUnique<ChildFrame>(
frame.output_surface_id, std::move(frame.frame), compositor_id_,
viewport_rect_for_tile_priority.IsEmpty(), transform_for_tile_priority,
@@ -252,7 +269,19 @@ bool BrowserViewRenderer::OnDrawHardware() {
ReturnUnusedResource(
current_compositor_frame_consumer_->PassUncommittedFrameOnUI());
current_compositor_frame_consumer_->SetFrameOnUI(std::move(child_frame));
- return true;
+}
+
+gfx::Rect BrowserViewRenderer::ComputeViewportRectForTilePriority() {
+ // If the WebView is on a layer, WebView does not know what transform is
+ // applied onto the layer so global visible rect does not make sense here.
+ // In this case, just use the surface rect for tiling.
+ // Leave viewport_rect_for_tile_priority empty if offscreen_pre_raster_ is on.
+ gfx::Rect viewport_rect_for_tile_priority;
+
+ if (!offscreen_pre_raster_ && !external_draw_constraints_.is_layer) {
+ viewport_rect_for_tile_priority = last_on_draw_global_visible_rect_;
+ }
+ return viewport_rect_for_tile_priority;
}
void BrowserViewRenderer::OnParentDrawConstraintsUpdated(
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/common/aw_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698