Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2280)

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 2174203002: OnDrawHardware() implementation with async messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Further changes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/hardware_renderer.cc
diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc
index 4a1f37cbe6c17cfb3f85169d344a4d73be11bb0f..31c1941168671ad7d416802c60a02947d2c77420 100644
--- a/android_webview/browser/hardware_renderer.cc
+++ b/android_webview/browser/hardware_renderer.cc
@@ -180,6 +180,10 @@ void HardwareRenderer::SetBackingFrameBufferObject(
void HardwareRenderer::ReturnResourcesInChildFrame() {
if (child_frame_.get() && child_frame_->frame.get()) {
cc::ReturnedResourceArray resources_to_return;
+ DCHECK(child_frame_);
+ DCHECK(child_frame_->frame);
+ DCHECK(child_frame_->frame->delegated_frame_data);
boliu 2016/07/29 00:48:21 crash looks like this DCHECK is failing the two D
ojars 2016/08/02 21:18:49 Done.
+ // DCHECK(child_frame_->frame->delegated_frame_data->resource_list);
cc::TransferableResource::ReturnResources(
child_frame_->frame->delegated_frame_data->resource_list,
&resources_to_return);

Powered by Google App Engine
This is Rietveld 408576698