content/public/browser/android/synchronous_compositor.h - Issue 2174203002: OnDrawHardware() implementation with async messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/android/synchronous_compositor.h

Issue 2174203002: OnDrawHardware() implementation with async messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implemented suggestions from previous code review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/synchronous_compositor_host.cc ('K') | « content/common/android/sync_compositor_messages.h ('k') | content/public/browser/android/synchronous_compositor_client.h » ('j') | content/renderer/android/synchronous_compositor_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/android/synchronous_compositor.h

diff --git a/content/public/browser/android/synchronous_compositor.h b/content/public/browser/android/synchronous_compositor.h

index 0b0b7ebccf3f7ecab4ba94fa5be1b291abdeb264..42282ebb101cc66cef6fc45c540d45036b320b6c 100644

--- a/content/public/browser/android/synchronous_compositor.h

+++ b/content/public/browser/android/synchronous_compositor.h

@@ -68,6 +68,12 @@ class CONTENT_EXPORT SynchronousCompositor {

const gfx::Rect& viewport_rect_for_tile_priority,

const gfx::Transform& transform_for_tile_priority) = 0;

+ // Same as DemandDrawHw, but uses asynchronous IPC messages.

boliu 2016/08/23 02:39:52 Calls SynchronousCompositorClient::OnDrawHardwareP

ojars 2016/08/23 21:58:43 Done.

+ virtual void DemandDrawHwAsync(

+ const gfx::Size& viewport_size,

+ const gfx::Rect& viewport_rect_for_tile_priority,

+ const gfx::Transform& transform_for_tile_priority) = 0;

// For delegated rendering, return resources from parent compositor to this.

// Note that all resources must be returned before ReleaseHwDraw.

virtual void ReturnResources(uint32_t output_surface_id,