android_webview/browser/hardware_renderer.cc - Issue 2174203002: OnDrawHardware() implementation with async messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 2174203002: OnDrawHardware() implementation with async messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added flag to branch old and new implementation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/browser_view_renderer.cc ('K') | « android_webview/browser/browser_view_renderer.cc ('k') | content/app/content_main_runner.cc » ('j') | content/app/content_main_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/hardware_renderer.cc

diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc

index 4a1f37cbe6c17cfb3f85169d344a4d73be11bb0f..9424fd183dbeb03f3ae6597e2715a3b4f8f42c4b 100644

--- a/android_webview/browser/hardware_renderer.cc

+++ b/android_webview/browser/hardware_renderer.cc

@@ -180,6 +180,7 @@ void HardwareRenderer::SetBackingFrameBufferObject(

void HardwareRenderer::ReturnResourcesInChildFrame() {

if (child_frame_.get() && child_frame_->frame.get()) {

cc::ReturnedResourceArray resources_to_return;

+ DCHECK(child_frame_->frame->delegated_frame_data);

cc::TransferableResource::ReturnResources(

child_frame_->frame->delegated_frame_data->resource_list,

&resources_to_return);