OnDrawHardware() implementation with async messages

content/browser/android/synchronous_compositor_host.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/synchronous_compositor_host.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
@@ skipping 52 matching lines @@
     RenderWidgetHostViewAndroid* rwhva,
     SynchronousCompositorClient* client,
     bool use_in_proc_software_draw)
     : rwhva_(rwhva),
       client_(client),
       ui_task_runner_(BrowserThread::GetTaskRunnerForThread(BrowserThread::UI)),
       process_id_(rwhva_->GetRenderWidgetHost()->GetProcess()->GetID()),
       routing_id_(rwhva_->GetRenderWidgetHost()->GetRoutingID()),
       sender_(rwhva_->GetRenderWidgetHost()),
       use_in_process_zero_copy_software_draw_(use_in_proc_software_draw),
+      //      did_receive_first_frame_synchronously_(false),
+      sync_call_count_(0u),
       bytes_limit_(0u),
       renderer_param_version_(0u),
       need_animate_scroll_(false),
       need_invalidate_count_(0u),
       did_activate_pending_tree_count_(0u) {
   client_->DidInitializeCompositor(this, process_id_, routing_id_);
 }
 
 SynchronousCompositorHost::~SynchronousCompositorHost() {
   client_->DidDestroyCompositor(this, process_id_, routing_id_);
 }
 
 bool SynchronousCompositorHost::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(SynchronousCompositorHost, message)
     IPC_MESSAGE_HANDLER(SyncCompositorHostMsg_OutputSurfaceCreated,
                         OutputSurfaceCreated)
     IPC_MESSAGE_HANDLER(SyncCompositorHostMsg_UpdateState, ProcessCommonParams)
+    IPC_MESSAGE_HANDLER(CompositorHostMsg_Frame, DemandDrawHwReceiveFrame)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
-SynchronousCompositor::Frame SynchronousCompositorHost::DemandDrawHw(
+SynchronousCompositor::Frame SynchronousCompositorHost::DemandDrawHw_Sync(
     const gfx::Size& surface_size,
     const gfx::Transform& transform,
     const gfx::Rect& viewport,
     const gfx::Rect& clip,
     const gfx::Rect& viewport_rect_for_tile_priority,
     const gfx::Transform& transform_for_tile_priority) {
   SyncCompositorDemandDrawHwParams params(surface_size, transform, viewport,
                                           clip, viewport_rect_for_tile_priority,
                                           transform_for_tile_priority);
   SynchronousCompositor::Frame frame;
   frame.frame.reset(new cc::CompositorFrame);
   SyncCompositorCommonRendererParams common_renderer_params;
   if (!sender_->Send(new SyncCompositorMsg_DemandDrawHw(
           routing_id_, params, &common_renderer_params,
           &frame.output_surface_id, frame.frame.get()))) {
     return SynchronousCompositor::Frame();
   }
   ProcessCommonParams(common_renderer_params);
   if (!frame.frame->delegated_frame_data) {
     // This can happen if compositor did not swap in this draw.
     frame.frame.reset();
   }
   if (frame.frame) {
     UpdateFrameMetaData(frame.frame->metadata.Clone());
   }
   return frame;
 }
 
+SynchronousCompositor::Frame SynchronousCompositorHost::DemandDrawHw(
+    const gfx::Size& surface_size,
+    const gfx::Transform& transform,
+    const gfx::Rect& viewport,
+    const gfx::Rect& clip,
+    const gfx::Rect& viewport_rect_for_tile_priority,
+    const gfx::Transform& transform_for_tile_priority) {
+  //  if (!did_receive_first_frame_synchronously_)
+  if (sync_call_count_++ < 60) {
+    //    did_receive_first_frame_synchronously_ = true;
+    return DemandDrawHw_Sync(surface_size, transform, viewport, clip,
+                             viewport_rect_for_tile_priority,
+                             transform_for_tile_priority);
+  }
+
+  SyncCompositorDemandDrawHwParams params(surface_size, transform, viewport,
+                                          clip, viewport_rect_for_tile_priority,
+                                          transform_for_tile_priority);
+  SynchronousCompositor::Frame frame;
+  frame.frame.reset(new cc::CompositorFrame);

[boliu, 2016/07/29 00:48:21]

you are creating a CompositorFrame here that's empty, ie without
delegated_frame_data, then in BVR, you are passing this empty frame into
ChildFrame, then into frame consumer etc

I think you should either make this method return void, or just remove all that
stuff in BVR after calling DemandDrawHw

+  //  SyncCompositorCommonRendererParams common_renderer_params;
+
+  /* Send an async message instead of a synchronous one.
+   * Currently not sure what to do in the analogous case
+   * when sending sync message returns false. */
+  //  if (!sender_->Send(new SyncCompositorMsg_DemandDrawHw(
+  //          routing_id_, params, &common_renderer_params,
+  //          &frame.output_surface_id, frame.frame.get()))) {
+  //    return SynchronousCompositor::Frame();
+  //  }
+
+  sender_->Send(new CompositorMsg_DemandDrawHw(routing_id_, params));
+
+  return frame;
+}
+
+void SynchronousCompositorHost::DemandDrawHwReceiveFrame(
+    uint32_t output_surface_id,
+    const cc::CompositorFrame& compositor_frame) {
+  //  ProcessCommonParams(common_renderer_params);
+  SynchronousCompositor::Frame frame;
+  frame.frame.reset(new cc::CompositorFrame);
+  frame.output_surface_id = output_surface_id;
+  //  *frame.frame.get() =  compositor_frame;
+  //  frame = compositor_frame;
+  // frame.frame.reset(&compositor_frame);
+  *frame.frame = std::move(const_cast<cc::CompositorFrame&>(compositor_frame));
+  frame.output_surface_id = output_surface_id;
+
+  if (!frame.frame->delegated_frame_data) {
+    // This can happen if compositor did not swap in this draw.
+    frame.frame.reset();
+  }
+  if (frame.frame) {
+    UpdateFrameMetaData(frame.frame->metadata.Clone());
+  }
+  //  return frame;
+  client_->OnDrawHardwareProcessFrame(std::move(frame));
+}
+
 void SynchronousCompositorHost::UpdateFrameMetaData(
     cc::CompositorFrameMetadata frame_metadata) {
   rwhva_->SynchronousFrameMetadata(std::move(frame_metadata));
 }
 
 namespace {
 
 class ScopedSetSkCanvas {
  public:
   explicit ScopedSetSkCanvas(SkCanvas* canvas) {
@@ skipping 246 matching lines @@
   if (params.page_scale_factor) {
     client_->UpdateRootLayerState(
         this, gfx::ScrollOffsetToVector2dF(params.total_scroll_offset),
         gfx::ScrollOffsetToVector2dF(params.max_scroll_offset),
         params.scrollable_size, params.page_scale_factor,
         params.min_page_scale_factor, params.max_page_scale_factor);
   }
 }
 
 }  // namespace content