Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: android_webview/browser/browser_view_renderer.h

Issue 2174203002: OnDrawHardware() implementation with async messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented suggestions from previous code review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
6 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 6 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 const gfx::Vector2dF& total_scroll_offset_dip, 122 const gfx::Vector2dF& total_scroll_offset_dip,
123 const gfx::Vector2dF& max_scroll_offset_dip, 123 const gfx::Vector2dF& max_scroll_offset_dip,
124 const gfx::SizeF& scrollable_size_dip, 124 const gfx::SizeF& scrollable_size_dip,
125 float page_scale_factor, 125 float page_scale_factor,
126 float min_page_scale_factor, 126 float min_page_scale_factor,
127 float max_page_scale_factor) override; 127 float max_page_scale_factor) override;
128 void DidOverscroll(content::SynchronousCompositor* compositor, 128 void DidOverscroll(content::SynchronousCompositor* compositor,
129 const gfx::Vector2dF& accumulated_overscroll, 129 const gfx::Vector2dF& accumulated_overscroll,
130 const gfx::Vector2dF& latest_overscroll_delta, 130 const gfx::Vector2dF& latest_overscroll_delta,
131 const gfx::Vector2dF& current_fling_velocity) override; 131 const gfx::Vector2dF& current_fling_velocity) override;
132 void OnDrawHardwareProcessFrame(
133 content::SynchronousCompositor::Frame frame) override;
132 134
133 // CompositorFrameProducer overrides 135 // CompositorFrameProducer overrides
134 void OnParentDrawConstraintsUpdated( 136 void OnParentDrawConstraintsUpdated(
135 CompositorFrameConsumer* compositor_frame_consumer) override; 137 CompositorFrameConsumer* compositor_frame_consumer) override;
136 void RemoveCompositorFrameConsumer( 138 void RemoveCompositorFrameConsumer(
137 CompositorFrameConsumer* compositor_frame_consumer) override; 139 CompositorFrameConsumer* compositor_frame_consumer) override;
138 140
139 void SetActiveCompositorID(const CompositorID& compositor_id); 141 void SetActiveCompositorID(const CompositorID& compositor_id);
140 142
141 // Visible for testing. 143 // Visible for testing.
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 gfx::Vector2dF max_scroll_offset_dip_; 216 gfx::Vector2dF max_scroll_offset_dip_;
215 217
216 // Used to prevent rounding errors from accumulating enough to generate 218 // Used to prevent rounding errors from accumulating enough to generate
217 // visible skew (especially noticeable when scrolling up and down in the same 219 // visible skew (especially noticeable when scrolling up and down in the same
218 // spot over a period of time). 220 // spot over a period of time).
219 // TODO(miletus): Make overscroll_rounding_error_ a gfx::ScrollOffset. 221 // TODO(miletus): Make overscroll_rounding_error_ a gfx::ScrollOffset.
220 gfx::Vector2dF overscroll_rounding_error_; 222 gfx::Vector2dF overscroll_rounding_error_;
221 223
222 ParentCompositorDrawConstraints external_draw_constraints_; 224 ParentCompositorDrawConstraints external_draw_constraints_;
223 225
226 gfx::Transform transform_for_tile_priority_;
227
228 gfx::Rect viewport_rect_for_tile_priority_;
boliu 2016/08/23 02:39:52 there is no need to save these two because they ar
ojars 2016/08/23 21:58:43 Done.
229
230 bool async_frame_messages_;
boliu 2016/08/23 02:39:52 const, and move it up next to ui_task_runner_ ie t
ojars 2016/08/23 21:58:42 Done.
231 bool frame_produced_;
232
224 DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer); 233 DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer);
225 }; 234 };
226 235
227 } // namespace android_webview 236 } // namespace android_webview
228 237
229 #endif // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 238 #endif // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer.cc » ('j') | android_webview/browser/browser_view_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698