Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2174183002: [Media Router] Fix typo in media_router_bindings.js (Closed)

Created:
4 years, 5 months ago by imcheng
Modified:
4 years, 5 months ago
Reviewers:
miu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Fix typo in media_router_bindings.js The typo was introduced in crrev.com/2111303003. There is no real impact since the handler function is set and used with the correct name everywhere else. BUG=625007 Committed: https://crrev.com/31b15d17748cedc65bdfb2d611a12bb66cedf234 Cr-Commit-Position: refs/heads/master@{#407373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
imcheng
PTAL
4 years, 5 months ago (2016-07-23 17:00:24 UTC) #2
miu
lgtm
4 years, 5 months ago (2016-07-23 20:23:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174183002/1
4 years, 5 months ago (2016-07-23 20:23:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 20:57:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 20:58:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31b15d17748cedc65bdfb2d611a12bb66cedf234
Cr-Commit-Position: refs/heads/master@{#407373}

Powered by Google App Engine
This is Rietveld 408576698