Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/wasm/test-run-wasm.cc

Issue 2174123002: [wasm] Add support for multiple indirect function tables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/wasm/wasm-module.cc ('K') | « src/wasm/wasm-module.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | test/mjsunit/wasm/wasm-module-builder.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm.cc
diff --git a/test/cctest/wasm/test-run-wasm.cc b/test/cctest/wasm/test-run-wasm.cc
index 88a1a442fb006721140ecaf154215f304b7a520d..9cfe175ff70147087b545de651ffed7c1dba7d70 100644
--- a/test/cctest/wasm/test-run-wasm.cc
+++ b/test/cctest/wasm/test-run-wasm.cc
@@ -2407,7 +2407,7 @@ WASM_EXEC_TEST(SimpleCallIndirect) {
module.AddSignature(sigs.d_dd());
// Function table.
- int table[] = {0, 1};
+ uint16_t table[] = {0, 1};
module.AddIndirectFunctionTable(table, 2);
ahaas 2016/07/25 19:23:45 could you use arraysize(table) here instead of the
ddchen 2016/07/25 22:17:36 Done.
module.PopulateIndirectFunctionTable();
@@ -2438,7 +2438,7 @@ WASM_EXEC_TEST(MultipleCallIndirect) {
module.AddSignature(sigs.d_dd());
// Function table.
- int table[] = {0, 1};
+ uint16_t table[] = {0, 1};
module.AddIndirectFunctionTable(table, 2);
ahaas 2016/07/25 19:23:45 same here.
ddchen 2016/07/25 22:17:36 Done.
module.PopulateIndirectFunctionTable();
« src/wasm/wasm-module.cc ('K') | « src/wasm/wasm-module.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | test/mjsunit/wasm/wasm-module-builder.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698