Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2174103002: Kitchen: always emit annotations if teeing. (Closed)

Created:
4 years, 5 months ago by dnj
Modified:
4 years, 5 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Kitchen: always emit annotations if teeing. Kitchen will not emit annotations if LogDog is enabled. However, if Kitchen is teeing, there may be additional consumers (e.g., Milo) reading the tee'd annotation stream. This makes it so that those annotations will continue to be emitted if teeing. BUG=chromium:630811 TEST=None Committed: https://chromium.googlesource.com/infra/infra/+/d2d28c63688f5697c611914c872da8971bde0cf5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M go/src/infra/tools/kitchen/cook.go View 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/tools/kitchen/cook_logdog.go View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 5 months ago (2016-07-23 01:33:39 UTC) #2
nodir
lgtm
4 years, 5 months ago (2016-07-23 02:02:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174103002/1
4 years, 5 months ago (2016-07-23 02:02:19 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 02:17:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/d2d28c63688f5697c611914c872da...

Powered by Google App Engine
This is Rietveld 408576698