Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2174073002: Adds functionality to update-w3c-test-expectations (Closed)

Created:
4 years, 5 months ago by dcampb
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds functionality to update-w3c-test-expectations This cl adds functionality to the skip so that it skips adding the failing test line if it already exists in TestExpectations. BUG=625254 Committed: https://crrev.com/e2d465d888b64ea9053cd03ab2af8623dc05a4de Cr-Commit-Position: refs/heads/master@{#407349}

Patch Set 1 #

Patch Set 2 : minor change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
dcampb
Please Note: I'm not sure if this is an issue or not, but this script ...
4 years, 5 months ago (2016-07-23 00:01:14 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-23 00:10:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174073002/1
4 years, 5 months ago (2016-07-23 00:11:57 UTC) #5
dcampb
minor change
4 years, 5 months ago (2016-07-23 01:26:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174073002/20001
4 years, 5 months ago (2016-07-23 01:27:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174073002/20001
4 years, 5 months ago (2016-07-23 01:33:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174073002/20001
4 years, 5 months ago (2016-07-23 01:37:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-23 04:02:27 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 04:04:25 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2d465d888b64ea9053cd03ab2af8623dc05a4de
Cr-Commit-Position: refs/heads/master@{#407349}

Powered by Google App Engine
This is Rietveld 408576698