Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4563)

Unified Diff: chrome/test/functional/test_clean_exit.py

Issue 217403002: Remove kChildCleanExit since it's not used anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/perf.py ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/test_clean_exit.py
===================================================================
--- chrome/test/functional/test_clean_exit.py (revision 260245)
+++ chrome/test/functional/test_clean_exit.py (working copy)
@@ -1,51 +0,0 @@
-#!/usr/bin/env python
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import logging
-import os
-import signal
-import subprocess
-import tempfile
-import unittest
-
-import pyauto_functional
-import pyauto
-import test_utils
-
-
-class SimpleTest(pyauto.PyUITest):
-
- def ExtraChromeFlags(self):
- """Ensures Chrome is launched with custom flags.
-
- Returns:
- A list of extra flags to pass to Chrome when it is launched.
- """
- fd, self._strace_log = tempfile.mkstemp()
- os.close(fd)
- extra_flags = ['--no-sandbox', '--child-clean-exit',
- '--renderer-cmd-prefix=/usr/bin/strace -o %s' %
- self._strace_log]
- logging.debug('Strace file is: %s' % self._strace_log)
- return pyauto.PyUITest.ExtraChromeFlags(self) + extra_flags
-
-
- def testCleanExit(self):
- """Ensures the renderer process cleanly exits."""
- url = self.GetHttpURLForDataPath('title2.html')
- self.NavigateToURL(url)
- os.kill(self.GetBrowserInfo()['browser_pid'], signal.SIGINT)
- self.WaitUntil(lambda: self._IsFileOpen(self._strace_log))
- strace_contents = open(self._strace_log).read()
- self.assertTrue('exit_group' in strace_contents)
- os.remove(self._strace_log)
-
- def _IsFileOpen(self, filename):
- p = subprocess.Popen(['lsof', filename])
- return p.communicate()[0] == ''
-
-
-if __name__ == '__main__':
- pyauto_functional.Main()
« no previous file with comments | « chrome/test/functional/perf.py ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698