Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2174023002: Add UseCounters for ViewportAPI (Closed)

Created:
4 years, 5 months ago by ymalik
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, rwlbuis, bokan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounters for ViewportAPI BUG=629801 Committed: https://crrev.com/5c3cff9bbeeb19a81879ce59089ee0d2e950ce0e Cr-Commit-Position: refs/heads/master@{#407391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -9 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/events/VisualViewportResizeEvent.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/events/VisualViewportResizeEvent.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/events/VisualViewportScrollEvent.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/events/VisualViewportScrollEvent.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ymalik
4 years, 5 months ago (2016-07-22 20:51:24 UTC) #2
dtapuska
On 2016/07/22 20:51:24, ymalik wrote: lgtm
4 years, 5 months ago (2016-07-22 20:56:26 UTC) #5
ymalik
+isherman for histograms.xml +skobes for core owner
4 years, 5 months ago (2016-07-22 21:00:57 UTC) #7
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-07-22 21:13:22 UTC) #8
skobes
lgtm
4 years, 5 months ago (2016-07-22 22:11:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174023002/1
4 years, 5 months ago (2016-07-24 18:34:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-24 19:48:29 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-24 19:49:47 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5c3cff9bbeeb19a81879ce59089ee0d2e950ce0e
Cr-Commit-Position: refs/heads/master@{#407391}

Powered by Google App Engine
This is Rietveld 408576698