Media Router Mojo: Use new wrapper types.

Media Router Mojo: Use new wrapper types.

Updates code to stop using the old mojo::String and mojo::Array types
and instead use the much-cleaner std::string and std::vector types
(a.k.a. the "new" mojo wrapper types for C++ code).

R=imcheng@chromium.org

Committed: https://crrev.com/6b1201a247659ad0e76cbacb0f382478d17e77ff
Cr-Commit-Position: refs/heads/master@{#407564}

[miu, 2016-07-22 22:40:19]

Patchset #1 (id:1) has been deleted

[miu, 2016-07-22 22:40:30]

The CQ bit was checked by miu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 22:41:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[miu, 2016-07-22 22:42:06]

imcheng: PTAL. I'm doing this upfront clean-up before I start landing more code
changes for the media router project. ;-)

[commit-bot: I haz the power, 2016-07-22 23:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 23:54:16]

Dry run: This issue passed the CQ dry run.

[imcheng, 2016-07-24 09:43:13]

lgtm

[miu, 2016-07-25 00:57:46]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2016-07-25 00:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 01:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 01:04:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[miu, 2016-07-25 02:20:03]

miu@chromium.org changed reviewers:
+ dcheng@chromium.org

[miu, 2016-07-25 02:20:04]

dcheng: SECURITY_OWNERS RS needed for trivial changes to
	chrome/browser/media/router/mojo/media_router_type_converters.cc.

[dcheng, 2016-07-25 02:58:20]

Also, this is good cleanup, but it would be even better to remove the type
converters completely. Is anyone able to work on https://crbug.com/629373 and
the associated issues that I found from looking around the media router mojo
stuff?

https://codereview.chromium.org/2173953003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_type_converters.cc (right):

https://codereview.chromium.org/2173953003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_type_converters.cc:79:
media_router::MediaSource(input->media_source.value_or(std::string())),
I'm not sure I understand the value of making this optional if we're just going
to transparently map it to the empty string. Why not just make it non-optional?

[miu, 2016-07-25 08:10:01]

On 2016/07/25 02:58:20, dcheng wrote:
> Also, this is good cleanup, but it would be even better to remove the type
> converters completely. Is anyone able to work on https://crbug.com/629373 and
> the associated issues that I found from looking around the media router mojo
> stuff?

I've assigned the bug to the appropriate individual. (I'm not on the Media
Router "core team.")

>
https://codereview.chromium.org/2173953003/diff/20001/chrome/browser/media/ro...
> chrome/browser/media/router/mojo/media_router_type_converters.cc:79:
> media_router::MediaSource(input->media_source.value_or(std::string())),
> I'm not sure I understand the value of making this optional if we're just
going
> to transparently map it to the empty string. Why not just make it
non-optional?

I was just maintaining the old behavior here for this clean-up. I'll chat with
imcheng@ tomorrow about this.

[dcheng, 2016-07-25 09:43:07]

LGTM, hopefully we can clean this up soon.

[mark a. foltz, 2016-07-25 18:39:38]

On 2016/07/25 at 09:43:07, dcheng wrote:
> LGTM, hopefully we can clean this up soon.

Thanks for the cleanup miu@.

FYI, I'm going to do something similar to presentation_service.mojom in
https://codereview.chromium.org/2174693004

[miu, 2016-07-25 19:32:43]

On 2016/07/25 09:43:07, dcheng wrote:
> LGTM, hopefully we can clean this up soon.

Yep. I'm always a fan of paying-down the technical debt when I can. ;-)

[miu, 2016-07-25 19:32:49]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 20:27:57]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-07-25 20:30:08]

Description was changed from

==========
Media Router Mojo: Use new wrapper types.

Updates code to stop using the old mojo::String and mojo::Array types
and instead use the much-cleaner std::string and std::vector types
(a.k.a. the "new" mojo wrapper types for C++ code).

R=imcheng@chromium.org
==========

to

==========
Media Router Mojo: Use new wrapper types.

Updates code to stop using the old mojo::String and mojo::Array types
and instead use the much-cleaner std::string and std::vector types
(a.k.a. the "new" mojo wrapper types for C++ code).

R=imcheng@chromium.org

Committed: https://crrev.com/6b1201a247659ad0e76cbacb0f382478d17e77ff
Cr-Commit-Position: refs/heads/master@{#407564}
==========

[commit-bot: I haz the power, 2016-07-25 20:30:10]

Patchset 1 (id:??) landed as
https://crrev.com/6b1201a247659ad0e76cbacb0f382478d17e77ff
Cr-Commit-Position: refs/heads/master@{#407564}