Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2173943003: Revert of [system-health] Add full Google Search story to the System Health story sets (Closed)

Created:
4 years, 5 months ago by Mark P
Modified:
4 years, 5 months ago
Reviewers:
nednguyen, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [system-health] Add full Google Search story to the System Health story sets (patchset #5 id:80001 of https://codereview.chromium.org/2148843002/ ) Reason for revert: I see a failure for benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.search:portal:google on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/50880 This is obviously related. Only one run with this patch has been completed thus far. Either this change caused the failure or, even if not, this change has caused this test to become flaky (I don't see any failures before this). Original issue's description: > [system-health] Add Google Search browsing story to the System Health story sets > > This patch adds a single 'search:portal' story (both desktop and > mobile) which does the following: > > 1. Open google.co.uk. > 2. Type 'what is science' and hit return. > 3. Scroll down to the Wikipedia result. > 4. Click on the Wikipedia result and wait until it loads. > > This is a prototype of the SH stories with same origin and cross-origin > navigtation (see > https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kwQEHMwI/#gid=712129109). > Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...) > will follow shortly (in subsequent CLs). > > BUG=589726 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/d6d935821c3afc9c0ce21e2a74a5411b59cb3c66 > Cr-Commit-Position: refs/heads/master@{#407225} TBR=nednguyen@google.com,petrcermak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589726 Committed: https://crrev.com/55c66f40f05f06f0f70564cfd61a2eb7653e9e8b Cr-Commit-Position: refs/heads/master@{#407257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -57 lines) Patch
M tools/perf/page_sets/data/system_health_desktop.json View 2 chunks +1 line, -4 lines 0 comments Download
D tools/perf/page_sets/data/system_health_desktop_022.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 2 chunks +1 line, -4 lines 0 comments Download
D tools/perf/page_sets/data/system_health_mobile_028.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 1 chunk +1 line, -2 lines 0 comments Download
D tools/perf/page_sets/system_health/searching_stories.py View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark P
Created Revert of [system-health] Add full Google Search story to the System Health story sets
4 years, 5 months ago (2016-07-22 20:48:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173943003/1
4 years, 5 months ago (2016-07-22 20:49:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 20:50:58 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 20:53:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55c66f40f05f06f0f70564cfd61a2eb7653e9e8b
Cr-Commit-Position: refs/heads/master@{#407257}

Powered by Google App Engine
This is Rietveld 408576698