components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java - Issue 2173923002: [Cronet] Mark request as complete when OutputStream fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

Issue 2173923002: [Cronet] Mark request as complete when OutputStream fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetFixedModeOutputStream.java ('k') | components/cronet/android/java/src/org/chromium/net/urlconnection/CronetOutputStream.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

index 191494fa5cd5ce7a00ffff5a9b5392340e7aa29a..227ae125f90f9b7c56d3bd64dfc7148fe7425c74 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

@@ -509,6 +509,7 @@ public class CronetHttpURLConnection extends HttpURLConnection {

if (mOutputStream != null) {

mOutputStream.setRequestCompleted(exception);

}

+ mHasResponse = true;

xunjieli 2016/07/22 20:15:24 Without this line, both tests will get stuck at ge

mMessageLoop.quit();

}