Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2173903002: Update AssertSingletonAllowed log message to reflect new restrictions w.r.t. CONTINUE_ON_SHUTDOWN t… (Closed)

Created:
4 years, 5 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews, Patrick Monette
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update AssertSingletonAllowed log message to reflect new restrictions w.r.t. CONTINUE_ON_SHUTDOWN tasks. This came up on issue 630059, the log message should reflect the new reasons why it may occur. BUG=630059 Committed: https://crrev.com/b6b9526b59d2f82b7dc6b4822643fabdc987a6b6 Cr-Commit-Position: refs/heads/master@{#407906}

Patch Set 1 #

Patch Set 2 : further improve message by suggesting a solution to detected problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M base/threading/thread_restrictions.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
gab
Dana PTAL, thanks!
4 years, 5 months ago (2016-07-22 16:55:15 UTC) #2
gab
CC pmonette since this is a follow-up to https://codereview.chromium.org/1904273002
4 years, 5 months ago (2016-07-22 16:55:36 UTC) #3
gab
ping Dana, mini-CL, thanks!
4 years, 4 months ago (2016-07-26 16:37:47 UTC) #4
danakj
LGTM
4 years, 4 months ago (2016-07-26 19:57:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173903002/20001
4 years, 4 months ago (2016-07-26 20:30:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 20:36:58 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:38:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6b9526b59d2f82b7dc6b4822643fabdc987a6b6
Cr-Commit-Position: refs/heads/master@{#407906}

Powered by Google App Engine
This is Rietveld 408576698