Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2173893002: [Merge M-53] NotSupportedError for payment apps without instruments. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M-53] NotSupportedError for payment apps without instruments. If the merchant website requests only a payment app that happens to not have any payment instruments and no ability to add an instrument from within PaymentRequest UI, then reject the show() promise with NotSupportedError. BUG=628685 Review-Url: https://codereview.chromium.org/2159513002 Cr-Commit-Position: refs/heads/master@{#406558} (cherry picked from commit 036c952c9a98ce9b25d7020fe865727b172d501a) Committed: https://chromium.googlesource.com/chromium/src/+/23b5a62b04e4594c310a80c9f0646cd87918101e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -90 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 8 chunks +28 lines, -17 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java View 5 chunks +114 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 5 months ago (2016-07-22 16:27:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23b5a62b04e4594c310a80c9f0646cd87918101e.

Powered by Google App Engine
This is Rietveld 408576698