Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(164)

Issue 2173883002: Fix infinite recursion crash in HarfBuzz' CoreText backend (Closed)

Created:
4 years, 4 months ago by drott
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek, eae, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix infinite recursion crash in HarfBuzz' CoreText backend The font cascade reconfiguration which was introduced as fix for AAT shaping performance regressions in crbug.com/547912 seems to occasionally cause CoreText crashes on OS X 10.9. We don't have a better way of detecting this than by OS or CoreText API version number. This is one of our top Mac crashers on Mac OS 10.9 with Chrome across versions [1]. This crash does not occur in newer versions of OS X and we can keep this important performance optimization enabled there. A big thanks to Robert Sesek (rsesek@) for the patient and thorough initial investigation. Discussing and working together on this issue we were able to identify the crash triggering code in HarfBuzz in this case. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=576941#c74 BUG=576941, 625902 Committed: https://crrev.com/64a2d4d02ea769c849df4718d196df12a3f79091 Cr-Commit-Position: refs/heads/master@{#407185}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check for lower than 10.10 instead, as CT reports 0x60001 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
drott
4 years, 4 months ago (2016-07-22 15:42:00 UTC) #4
Robert Sesek
https://codereview.chromium.org/2173883002/diff/1/third_party/harfbuzz-ng/src/hb-coretext.cc File third_party/harfbuzz-ng/src/hb-coretext.cc (right): https://codereview.chromium.org/2173883002/diff/1/third_party/harfbuzz-ng/src/hb-coretext.cc#newcode153 third_party/harfbuzz-ng/src/hb-coretext.cc:153: if (&CTGetCoreTextVersion != NULL && CTGetCoreTextVersion() <= kCTVersionNumber10_9) This ...
4 years, 4 months ago (2016-07-22 15:56:11 UTC) #6
drott
On 2016/07/22 at 15:56:11, rsesek wrote: > That prints: > CTGetCoreTextVersion = 0x7fff8d6258b8 ==> 393217 ...
4 years, 4 months ago (2016-07-22 16:00:12 UTC) #12
Robert Sesek
LGTM. Verified in my 10.9 VM using the repro information in bug 625902.
4 years, 4 months ago (2016-07-22 16:02:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173883002/40001
4 years, 4 months ago (2016-07-22 16:04:06 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-07-22 17:15:46 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/64a2d4d02ea769c849df4718d196df12a3f79091 Cr-Commit-Position: refs/heads/master@{#407185}
4 years, 4 months ago (2016-07-22 17:18:54 UTC) #19
eae
LGTM
4 years, 4 months ago (2016-07-22 17:21:18 UTC) #20
behdad
4 years, 4 months ago (2016-07-22 21:08:32 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698