third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp - Issue 2173873003: Cancel image loads if decoding failed (attempt #2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 2173873003: Cancel image loads if decoding failed (attempt #2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix UAF Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTestWoPlatform.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

index b72b9dfafe2b4d6d11edc1db93f61995f6d4aef3..ffac7d1a438f75210597e4afe4fb833e8bf35da4 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

@@ -360,7 +360,7 @@ TEST_F(DeferredImageDecoderTest, smallerFrameCount)

TEST_F(DeferredImageDecoderTest, frameOpacity)

{

- std::unique_ptr<ImageDecoder> actualDecoder = ImageDecoder::create(*m_data,

+ std::unique_ptr<ImageDecoder> actualDecoder = ImageDecoder::create(ImageDecoder::determineImageType(*m_data),

ImageDecoder::AlphaPremultiplied, ImageDecoder::GammaAndColorProfileApplied);

std::unique_ptr<DeferredImageDecoder> decoder = DeferredImageDecoder::createForTesting(std::move(actualDecoder));

decoder->setData(*m_data, true);