third_party/WebKit/Source/platform/graphics/BitmapImage.h - Issue 2173873003: Cancel image loads if decoding failed (attempt #2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/BitmapImage.h

Issue 2173873003: Cancel image loads if decoding failed (attempt #2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix UAF Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/BitmapImage.h

diff --git a/third_party/WebKit/Source/platform/graphics/BitmapImage.h b/third_party/WebKit/Source/platform/graphics/BitmapImage.h

index 590b1998789e138e99803d3bea74e7609a0da24e..68d1a1ef82abebd641376ca405a49e0c30ed7fe3 100644

--- a/third_party/WebKit/Source/platform/graphics/BitmapImage.h

+++ b/third_party/WebKit/Source/platform/graphics/BitmapImage.h

@@ -65,8 +65,9 @@ public:

IntSize sizeRespectingOrientation() const;

bool getHotSpot(IntPoint&) const override;

String filenameExtension() const override;

- bool setData(PassRefPtr<SharedBuffer> data, bool allDataReceived) override;

- bool dataChanged(bool allDataReceived) override;

+ SizeAvailability setData(PassRefPtr<SharedBuffer> data, bool allDataReceived) override;

+ SizeAvailability dataChanged(bool allDataReceived) override;

bool isAllDataReceived() const { return m_allDataReceived; }

bool hasColorProfile() const;