Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTestWoPlatform.cpp

Issue 2173873003: Cancel image loads if decoding failed (attempt #2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix UAF Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/DeferredImageDecoder.h" 5 #include "platform/graphics/DeferredImageDecoder.h"
6 6
7 #include "platform/SharedBuffer.h" 7 #include "platform/SharedBuffer.h"
8 #include "platform/image-decoders/ImageDecoderTestHelpers.h" 8 #include "platform/image-decoders/ImageDecoderTestHelpers.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "third_party/skia/include/core/SkImage.h" 10 #include "third_party/skia/include/core/SkImage.h"
(...skipping 17 matching lines...) Expand all
28 * 28 *
29 * @param fileName File to decode 29 * @param fileName File to decode
30 * @param bytesForFirstFrame Number of bytes needed to return an SkImage 30 * @param bytesForFirstFrame Number of bytes needed to return an SkImage
31 * @param laterFrame Frame to decode with almost complete data. Can be 0. 31 * @param laterFrame Frame to decode with almost complete data. Can be 0.
32 */ 32 */
33 static void mixImages(const char* fileName, size_t bytesForFirstFrame, size_t la terFrame) 33 static void mixImages(const char* fileName, size_t bytesForFirstFrame, size_t la terFrame)
34 { 34 {
35 RefPtr<SharedBuffer> file = readFile(fileName); 35 RefPtr<SharedBuffer> file = readFile(fileName);
36 ASSERT_NE(file, nullptr); 36 ASSERT_NE(file, nullptr);
37 37
38 std::unique_ptr<DeferredImageDecoder> decoder = DeferredImageDecoder::create (*file.get(), ImageDecoder::AlphaPremultiplied, ImageDecoder::GammaAndColorProfi leIgnored); 38 std::unique_ptr<DeferredImageDecoder> decoder = DeferredImageDecoder::create (ImageDecoder::determineImageType(*file.get()), ImageDecoder::AlphaPremultiplied , ImageDecoder::GammaAndColorProfileIgnored);
39 ASSERT_TRUE(decoder.get()); 39 ASSERT_TRUE(decoder.get());
40 40
41 RefPtr<SharedBuffer> partialFile = SharedBuffer::create(file->data(), bytesF orFirstFrame); 41 RefPtr<SharedBuffer> partialFile = SharedBuffer::create(file->data(), bytesF orFirstFrame);
42 decoder->setData(*partialFile.get(), false); 42 decoder->setData(*partialFile.get(), false);
43 RefPtr<SkImage> partialImage = decoder->createFrameAtIndex(0); 43 RefPtr<SkImage> partialImage = decoder->createFrameAtIndex(0);
44 44
45 RefPtr<SharedBuffer> almostCompleteFile = SharedBuffer::create(file->data(), file->size() - 1); 45 RefPtr<SharedBuffer> almostCompleteFile = SharedBuffer::create(file->data(), file->size() - 1);
46 decoder->setData(*almostCompleteFile.get(), false); 46 decoder->setData(*almostCompleteFile.get(), false);
47 RefPtr<SkImage> imageWithMoreData = decoder->createFrameAtIndex(laterFrame); 47 RefPtr<SkImage> imageWithMoreData = decoder->createFrameAtIndex(laterFrame);
48 48
(...skipping 25 matching lines...) Expand all
74 { 74 {
75 mixImages("/LayoutTests/fast/images/resources/lenna.bmp", 122u, 0u); 75 mixImages("/LayoutTests/fast/images/resources/lenna.bmp", 122u, 0u);
76 } 76 }
77 77
78 TEST(DeferredImageDecoderTestWoPlatform, mixImagesIco) 78 TEST(DeferredImageDecoderTestWoPlatform, mixImagesIco)
79 { 79 {
80 mixImages("/LayoutTests/fast/images/resources/wrong-frame-dimensions.ico", 1 376u, 1u); 80 mixImages("/LayoutTests/fast/images/resources/wrong-frame-dimensions.ico", 1 376u, 1u);
81 } 81 }
82 82
83 } // namespace blink 83 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698