Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2173873002: iOS: Re-add bits of GTM we actually use. (Closed)

Created:
4 years, 5 months ago by bzanotti
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

iOS: Re-add bits of GTM we actually use. Also adds a unit test using the function that is used downstream to prevent this from happening again. BUG=630260 Committed: https://crrev.com/0a30b3b174cf260df6cd9a4e6fd96bc87b840e59 Cr-Commit-Position: refs/heads/master@{#407213}

Patch Set 1 #

Patch Set 2 : Fix ios_chrome_tests.gyp #

Patch Set 3 : Fix google_toolbox_for_mac.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M ios/chrome/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/test/google_toolbox_unittest.mm View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/google_toolbox_for_mac/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp View 1 2 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
bzanotti
Please take a look.
4 years, 5 months ago (2016-07-22 15:10:34 UTC) #2
sdefresne
lgtm
4 years, 5 months ago (2016-07-22 15:15:46 UTC) #4
Avi (use Gerrit)
lgtm stampity stamp
4 years, 5 months ago (2016-07-22 15:46:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173873002/20001
4 years, 5 months ago (2016-07-22 16:17:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/40120)
4 years, 5 months ago (2016-07-22 16:37:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173873002/40001
4 years, 5 months ago (2016-07-22 17:09:02 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-22 18:38:24 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:41:39 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a30b3b174cf260df6cd9a4e6fd96bc87b840e59
Cr-Commit-Position: refs/heads/master@{#407213}

Powered by Google App Engine
This is Rietveld 408576698