Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2173853003: Always init SkPathRef variables. (Closed)

Created:
4 years, 5 months ago by Stephen White
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add back comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkPathRef.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Stephen White
Brian: PTAL. Thanks!
4 years, 5 months ago (2016-07-22 19:13:28 UTC) #6
bsalomon
lgtm, but can we keep the comment, it explains why start is initialized to an ...
4 years, 5 months ago (2016-07-22 20:24:37 UTC) #9
Stephen White
On 2016/07/22 20:24:37, bsalomon wrote: > lgtm, but can we keep the comment, it explains ...
4 years, 5 months ago (2016-07-22 20:26:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173853003/20001
4 years, 5 months ago (2016-07-22 20:27:11 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 20:51:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9c1d45d986f3c58593fde0fd62ab22e056dd3881

Powered by Google App Engine
This is Rietveld 408576698