git recipe_module: add experimental git-cache support.

git recipe_module: add experimental git-cache support.

BUG=630601
R=phajdan.jr@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/dc24ee1a9928883da6234534d5f44b409959ac6a

[tandrii(chromium), 2016-07-22 12:53:50]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 12:53:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 12:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 12:57:02]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-07-22 12:57:18]

LGTM w/comment

https://codereview.chromium.org/2173823002/diff/1/recipe_modules/git/api.py
File recipe_modules/git/api.py (right):

https://codereview.chromium.org/2173823002/diff/1/recipe_modules/git/api.py#n...
recipe_modules/git/api.py:137: use_git_cache_dir=None):
nit: use_ prefix suggests a boolean; could you rename to git_cache_dir?

As an alternative, make it a boolean, depend on infra_paths module and use
self.m.path['git_cache'] for the git cache dir.

[tandrii(chromium), 2016-07-22 13:09:10]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 13:09:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-22 13:09:26]

Done. WDYT?

[commit-bot: I haz the power, 2016-07-22 13:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 13:12:01]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-07-22 13:12:30]

LGTM!

[tandrii(chromium), 2016-07-22 13:21:46]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-07-22 13:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 13:25:10]

Description was changed from

==========
git recipe_module: add experimental git-cache support.

BUG=630601
R=phajdan.jr@chromium.org
==========

to

==========
git recipe_module: add experimental git-cache support.

BUG=630601
R=phajdan.jr@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dc24ee1a992888...
==========

[commit-bot: I haz the power, 2016-07-22 13:25:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dc24ee1a992888...