experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp - Issue 21738005: pdfviewer: add indexed rbg image support, enhanche caching(setData) for SkPdfObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp

Issue 21738005: pdfviewer: add indexed rbg image support, enhanche caching(setData) for SkPdfObject (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp ('k') | experimental/PdfViewer/pdfparser/native/SkPdfObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp

===================================================================

--- experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp (revision 10523)

+++ experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp (working copy)

@@ -32,9 +32,11 @@

static void TRACE_INDENT(int level, const char* type) {

static int id = 0;

id++;

+#if 0

if (478613 == id) {

printf("break;\n");

}

+#endif

// all types should have 2 letters, so the text is alligned nicely

printf("\n%10i %15s: ", id, type);

for (int i = 0 ; i < level; i++) {

@@ -158,7 +160,6 @@

}

array->appendInArray(newObj);

}

- printf("break;\n"); // DO NOT SUBMIT!

// TODO(edisonn): report not reached, we should never get here

// TODO(edisonn): there might be a bug here, enable an assert and run it on files

// or it might be that the files were actually corrupted

@@ -954,9 +955,11 @@

#ifdef PDF_TRACE_READ_TOKEN

static int read_op = 0;

read_op++;

+#if 0

if (548 == read_op) {

printf("break;\n");

}

+#endif

printf("%i READ %s %s\n", read_op, token->fType == kKeyword_TokenType ? "Keyword" : "Object", token->fKeyword ? std::string(token->fKeyword, token->fKeywordLength).c_str() : token->fObject->toString().c_str());

#endif