Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2173773003: Fix possible memory leaks. (Closed)

Created:
4 years, 5 months ago by kuznetsovs
Modified:
4 years, 4 months ago
Reviewers:
Miguel Garcia, Ted C, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix possible memory leaks. WebsiteSettingsUI::SetPermissionInfo doc says 'The callee is expected to take ownership of the objects in |chosen_object_info_list|.' Android implementations don't do anything with |chosen_object_info_list|, so memory leaks are possible. R=yfriedman@chromium.org BUG=424667 Committed: https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8 Cr-Commit-Position: refs/heads/master@{#407734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/android/connection_info_popup_android.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kuznetsovs
4 years, 5 months ago (2016-07-22 12:31:35 UTC) #1
kuznetsovs
4 years, 5 months ago (2016-07-25 11:00:30 UTC) #3
Yaron
lgtm
4 years, 5 months ago (2016-07-25 14:18:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173773003/1
4 years, 4 months ago (2016-07-26 07:57:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 08:22:17 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 08:23:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8
Cr-Commit-Position: refs/heads/master@{#407734}

Powered by Google App Engine
This is Rietveld 408576698