Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issue 2173773002: [heap] Give marking functions for incremental marking more precise names. (Closed)

Created:
4 years, 5 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Give marking functions for incremental marking more precise names. BUG= Committed: https://crrev.com/4ac08c97f0c26cca3c0687b7349c929a4db2df43 Cr-Commit-Position: refs/heads/master@{#38141}

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : fix compile #

Patch Set 4 : fix compile #

Patch Set 5 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M src/heap/heap.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 6 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Hannes Payer (out of office)
4 years, 4 months ago (2016-07-26 17:16:30 UTC) #2
ulan
lgtm
4 years, 4 months ago (2016-07-26 17:19:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173773002/1
4 years, 4 months ago (2016-07-26 17:21:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/1085) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-07-26 17:24:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173773002/20001
4 years, 4 months ago (2016-07-28 13:50:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9877)
4 years, 4 months ago (2016-07-28 13:58:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173773002/40001
4 years, 4 months ago (2016-07-28 14:19:52 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 14:44:00 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4ac08c97f0c26cca3c0687b7349c929a4db2df43 Cr-Commit-Position: refs/heads/master@{#38141}
4 years, 4 months ago (2016-07-28 14:45:27 UTC) #18
Michael Hablich
4 years, 4 months ago (2016-07-29 11:02:07 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2197583002/ by hablich@chromium.org.

The reason for reverting is: Breaks Roll
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

Powered by Google App Engine
This is Rietveld 408576698