Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2173683003: Revert of bot_update: fix git dir check (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of bot_update: fix git dir check (patchset #1 id:1 of https://codereview.chromium.org/2174923002/ ) Reason for revert: this is wrong. if directory is not empty, git clone fails Original issue's description: > bot_update: fix git dir check > > existance of a dir does not mean it is a git repo. Check .git dir > presence instead. > > This is the reason why swarmbucket build.git builds fail. > > TBR=hinoka@chromium.org > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/cdac80c9fb4768bdc5bc42734e852e1f216224c9 TBR=hinoka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b96f2d5b1dd025c4392bc9b41a95d75e749e04d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nodir
Created Revert of bot_update: fix git dir check
4 years, 5 months ago (2016-07-22 22:49:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173683003/1
4 years, 5 months ago (2016-07-22 22:49:06 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 22:49:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b96f2d5b1dd025...

Powered by Google App Engine
This is Rietveld 408576698