Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 217363002: Fix Host stuck at the right side (Closed)

Created:
6 years, 8 months ago by kelvinp
Modified:
6 years, 8 months ago
Reviewers:
Sergey Ulanov, darrenwallace, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Fix Host stuck at the right side Cause: This bug only repro on chrome v33 and v34 <div class="vertically-centered"> <div class="horizontally-centered"> <div id="video-container"> <video id="mediasource-video-output"></video> <div id="client-plugin-container"></div> </div> </div> </div> Due to a chrome layout bug, the width of video-container collapses to 0 when the zoom level is greater than 100%. As a result, the flexbox defined in horizonally-centered fails to center the element. Fix: Set width=100% on video-container so that its width remains valid. Since video-container now sizes to the parent, we need to move the horizontal-centered flexbox to the children of video-container. BUG=357114 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260386

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix webapp display for large screens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/webapp/main.css View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kelvinp
Please take a look at the fix. If everything goes well, I will create Frankenstein ...
6 years, 8 months ago (2014-03-28 19:59:10 UTC) #1
Jamie
lgtm https://codereview.chromium.org/217363002/diff/1/remoting/webapp/html/client_plugin.html File remoting/webapp/html/client_plugin.html (right): https://codereview.chromium.org/217363002/diff/1/remoting/webapp/html/client_plugin.html#newcode8 remoting/webapp/html/client_plugin.html:8: <video id="mediasource-video-output"></video> Not necessary for the Franken-build, but ...
6 years, 8 months ago (2014-03-28 20:16:51 UTC) #2
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 8 months ago (2014-03-28 22:15:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/217363002/1
6 years, 8 months ago (2014-03-28 22:16:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 03:07:11 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-29 03:07:11 UTC) #6
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 8 months ago (2014-03-29 06:42:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/217363002/1
6 years, 8 months ago (2014-03-29 06:42:53 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 08:30:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 08:30:20 UTC) #10
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 8 months ago (2014-03-29 16:14:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/217363002/1
6 years, 8 months ago (2014-03-29 16:14:16 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:48:05 UTC) #13
Message was sent while issue was closed.
Change committed as 260386

Powered by Google App Engine
This is Rietveld 408576698