Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2173623003: Add "Failed" custom element state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
index e0567a9029abf1241defa983378311411da865fd..58cdf981056351cd6189c98c31e1554929b28748 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
@@ -120,8 +120,10 @@ void CustomElementDefinition::upgrade(Element* element)
DCHECK_EQ(m_constructionStack.size(), depth); // It's a *stack*.
m_constructionStack.removeLast();
- if (!succeeded)
+ if (!succeeded) {
+ element->setCustomElementState(CustomElementState::Failed);
return;
+ }
CHECK(element->getCustomElementState() == CustomElementState::Custom);
}

Powered by Google App Engine
This is Rietveld 408576698