third_party/WebKit/Source/core/dom/Element.h - Issue 2173623003: Add "Failed" custom element state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2173623003: Add "Failed" custom element state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and cleanup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.h

diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h

index bad1a3842b9ac576d96dd847cf853f43a52e35ed..4bcea2b68ecd5cb692bd59b082fe41e7bd433176 100644

--- a/third_party/WebKit/Source/core/dom/Element.h

+++ b/third_party/WebKit/Source/core/dom/Element.h

@@ -374,7 +374,7 @@ public:

void setIsInCanvasSubtree(bool value) { setElementFlag(IsInCanvasSubtree, value); }

bool isInCanvasSubtree() const { return hasElementFlag(IsInCanvasSubtree); }

- bool isDefined() const { return getCustomElementState() != CustomElementState::Undefined; }

+ bool isDefined() const;

dominicc (has gone to gerrit) 2016/07/26 05:47:42 Maybe we want to keep inlining this?

bool isUpgradedV0CustomElement() { return getV0CustomElementState() == V0Upgraded; }

bool isUnresolvedV0CustomElement() { return getV0CustomElementState() == V0WaitingForUpgrade; }