content/browser/renderer_host/input/input_router_impl.cc - Issue 2173603002: Filter GestureFlingStarts with Vx=Vy=0 in RenderWidgetHostViewChildFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 2173603002: Filter GestureFlingStarts with Vx=Vy=0 in RenderWidgetHostViewChildFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarify comments, and include reference to RWHVA::FilterInputEvent(). Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/renderer_host/render_widget_host_input_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_impl.cc

diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc

index ab6ab3e5d40e55db4f257d9847b5ab8e3091ab49..cf7e7cd422824f187ad152a58b5f6b10e1c5dc51 100644

--- a/content/browser/renderer_host/input/input_router_impl.cc

+++ b/content/browser/renderer_host/input/input_router_impl.cc

@@ -429,6 +429,12 @@ bool InputRouterImpl::OfferToClient(const WebInputEvent& input_event,

bool InputRouterImpl::OfferToRenderer(const WebInputEvent& input_event,

const ui::LatencyInfo& latency_info,

InputEventDispatchType dispatch_type) {

+ DCHECK(input_event.type != blink::WebInputEvent::GestureFlingStart ||

+ static_cast<const blink::WebGestureEvent&>(input_event)

+ .data.flingStart.velocityX != 0.0 ||

+ static_cast<const blink::WebGestureEvent&>(input_event)

+ .data.flingStart.velocityY != 0.0);

// This conversion is temporary. WebInputEvent should be generated

// directly from ui::Event with the viewport coordinates. See

// crbug.com/563730.