Newly created live regions should fire a private notification on the Mac.

Newly created live regions should fire a private notification on the Mac.

BUG=590341
TESTED=Voiceover
R=dmazzoni@chromium.org

Committed: https://crrev.com/a7ee1d4d340cf4a8802a1676a5016ee3b8f10637
Cr-Commit-Position: refs/heads/master@{#416317}

[dmazzoni, 2016-07-26 22:21:43]

Any luck getting this to work?

Maybe check the WebKit bug with AXLiveRegionCreated was added?
https://bugs.webkit.org/show_bug.cgi?id=124381

Should we ask Apple?

[dmazzoni, 2016-07-27 19:27:10]

The code is fine, I'm just trying to figure out if it does anything. It sounds
like it doesn't help with role=alert. Does it help with anything else?

Also, we have some code that refreshes the page when a new live region is
created because older versions of VoiceOver didn't support this event. We should
probably stop using that code in newer OS X versions

[chromium-reviews, 2016-07-27 19:47:51]

It doesn't help with anything yet, but the same code is in WebKit so I 
am curious what difference does my code have with what WebKit does.

According to the bug you sent me, they included this notification only 
for better reliability, so the actual announcement might be triggered by 
something else?

Yes, I saw the old code but didn't touch it for now.

Nektarios.


On 7/27/2016 3:27 PM, dmazzoni@chromium.org wrote:
> The code is fine, I'm just trying to figure out if it does anything. 
> It sounds
> like it doesn't help with role=alert. Does it help with anything else?
>
> Also, we have some code that refreshes the page when a new live region is
> created because older versions of VoiceOver didn't support this event. 
> We should
> probably stop using that code in newer OS X versions
>
>
>
> https://codereview.chromium.org/2173563005/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-08-08 18:49:05]

I think I figured out what's going on. See the
comment below.

https://codereview.chromium.org/2173563005/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_manager_mac.mm (right):

https://codereview.chromium.org/2173563005/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_manager_mac.mm:398: // This
code is to work around a bug in VoiceOver, where a new live
I think you should try deleting the following block of code.
My guess is that it's getting in the way of VoiceOver
speaking a live region created event because it destroys
and recreates the native accessibility tree.

[dmazzoni, 2016-08-15 18:34:12]

Users are reporting a problem where the page refreshes constantly while
loading, and I think this is actually the same issue.

See this bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=637895

[dmazzoni, 2016-08-29 17:20:00]

Ping - could you look at this again or would you like me to?

I suspect that if you get rid of the code that refreshes the
whole accessibility tree when a new live region is created for
newer OS X versions, that will fix alerts and also address
another user bug. I'd really like to see if we could do that.

[nektarios, 2016-08-29 18:35:45]

Good idea, but removing legacy code doesn't work, both in fixing alerts and the
constant reloading seen on some sites.

[dmazzoni, 2016-09-02 15:57:52]

lgtm

OK, let's land this change and then ask Apple why it's still
not working.

[nektarios, 2016-09-02 18:06:21]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-09-02 18:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 19:11:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 19:13:41]

Description was changed from

==========
Newly created live regions should fire a private notification on the Mac.

BUG=590341
TESTED=Voiceover
R=dmazzoni@chromium.org
==========

to

==========
Newly created live regions should fire a private notification on the Mac.

BUG=590341
TESTED=Voiceover
R=dmazzoni@chromium.org

Committed: https://crrev.com/a7ee1d4d340cf4a8802a1676a5016ee3b8f10637
Cr-Commit-Position: refs/heads/master@{#416317}
==========

[commit-bot: I haz the power, 2016-09-02 19:13:42]

Patchset 3 (id:??) landed as
https://crrev.com/a7ee1d4d340cf4a8802a1676a5016ee3b8f10637
Cr-Commit-Position: refs/heads/master@{#416317}