Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2739)

Unified Diff: blimp/client/app/android/java/res/values/arrays.xml

Issue 2173563003: Blimp settings UI integration for Chrome, everything still lives in Blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add v7 support jar in Blimp build.gn, to make trybot happy. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/android/java/res/values/arrays.xml
diff --git a/blimp/client/app/android/java/res/values/arrays.xml b/blimp/client/app/android/java/res/values/arrays.xml
index 9dfca1f789a07b6f85aa21160f53c1deed9d58d0..055290f1366a3702ab3cf993f0ca78c5c4cceef2 100644
--- a/blimp/client/app/android/java/res/values/arrays.xml
+++ b/blimp/client/app/android/java/res/values/arrays.xml
@@ -14,4 +14,17 @@
<item>https://staging-blimp-pa.sandbox.googleapis.com/v1/assignment</item>
<item>https://dev-blimp-pa.sandbox.googleapis.com/v1/assignment</item>
</string-array>
+
+ <!-- Blimp preferences for Chrome, all array names should prefix with blimp -->
David Trainor- moved to gerrit 2016/07/22 16:51:42 Add a . after blimp.
xingliu 2016/07/23 23:50:36 Done.
+ <!-- These need to port to Chrome in the future. -->
David Trainor- moved to gerrit 2016/07/22 16:51:42 Could you explain why? If we do need to, file a b
xingliu 2016/07/23 23:50:35 Done.
+ <string-array name="blimp_assigner_envs">
+ <item>Production</item>
+ <item>Staging</item>
+ <item>Development</item>
+ </string-array>
+ <string-array name="blimp_assigner_urls">
+ <item>https://blimp-pa.googleapis.com/v1/assignment</item>
+ <item>https://staging-blimp-pa.sandbox.googleapis.com/v1/assignment</item>
+ <item>https://dev-blimp-pa.sandbox.googleapis.com/v1/assignment</item>
+ </string-array>
</resources>

Powered by Google App Engine
This is Rietveld 408576698