Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2173553002: DevTools: Immediately hide on scroll for source color picker (Closed)

Created:
4 years, 5 months ago by flandy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Immediately hide on scroll for source color picker Move the timeout for handling scroll from CodeMirrorTextEditor to SourceFrame. R=lushnikov Committed: https://crrev.com/d60f0938f1179b58551bef53b6613eb7ecb7123b Cr-Commit-Position: refs/heads/master@{#407040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
flandy
Please take a look
4 years, 5 months ago (2016-07-21 22:40:03 UTC) #1
lushnikov
lgtm
4 years, 5 months ago (2016-07-21 23:01:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173553002/1
4 years, 5 months ago (2016-07-21 23:04:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:44:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:46:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d60f0938f1179b58551bef53b6613eb7ecb7123b
Cr-Commit-Position: refs/heads/master@{#407040}

Powered by Google App Engine
This is Rietveld 408576698