Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2173533002: More fixes for the Windows GN build. (Closed)

Created:
4 years, 5 months ago by Sébastien Marchand
Modified:
4 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, huangs+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More fixes for the Windows GN build. - symupload.exe is the same binary, but with the LargeAddressAware bit set (https://msdn.microsoft.com/en-us/library/wz223b1z.aspx) - mini_installer_version.rc should be mini_installer_exe_version.rc and should be placed in the out directory (according to the GYP files). - Cleaned up the courgette64 copy rule. TBR=mark@chromium.org BUG=629709 Committed: https://crrev.com/37cfb345885a1de370ba7d8258d6d5c9144fd254 Cr-Commit-Position: refs/heads/master@{#408162}

Patch Set 1 #

Patch Set 2 : Revert a NaCl change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M breakpad/symupload.exe View Binary file 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M courgette/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Sébastien Marchand
+wfh@
4 years, 5 months ago (2016-07-21 21:31:17 UTC) #5
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 21:36:38 UTC) #6
Sébastien Marchand
+mark@ for owner approval.
4 years, 5 months ago (2016-07-21 22:00:18 UTC) #8
Sébastien Marchand
TBR'ing Mark as he's ooo today and this is a minor change in breakpad (a ...
4 years, 4 months ago (2016-07-26 17:30:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173533002/20001
4 years, 4 months ago (2016-07-26 18:02:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/110955)
4 years, 4 months ago (2016-07-26 19:58:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173533002/20001
4 years, 4 months ago (2016-07-27 16:40:18 UTC) #16
Mark Mentovai
LGTM
4 years, 4 months ago (2016-07-27 16:52:12 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 17:14:41 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:16:38 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37cfb345885a1de370ba7d8258d6d5c9144fd254
Cr-Commit-Position: refs/heads/master@{#408162}

Powered by Google App Engine
This is Rietveld 408576698