Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 217353002: Fix click-to-play support in chromoting client (Closed)

Created:
6 years, 9 months ago by Sergey Ulanov
Modified:
6 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Fix click-to-play support in chromoting client Click-to-play was broken when the plugin resizing code was changed to update plugin style instead of width/height fields directly. Problem is that remoting.ClientPlugin.showPluginForClickToPlay() was still using trying to set width/height which are overridden by the CSS size. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M remoting/webapp/client_plugin.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Sergey Ulanov
6 years, 9 months ago (2014-03-28 19:52:15 UTC) #1
Jamie
lgtm
6 years, 9 months ago (2014-03-28 19:54:50 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-03-28 23:11:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/217353002/1
6 years, 8 months ago (2014-03-28 23:15:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 00:44:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 00:44:57 UTC) #6
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-03-29 00:49:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/217353002/1
6 years, 8 months ago (2014-03-29 00:52:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 01:28:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 01:28:22 UTC) #10
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-03-29 01:32:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/217353002/1
6 years, 8 months ago (2014-03-29 01:35:18 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 01:37:54 UTC) #13
Message was sent while issue was closed.
Change committed as 260337

Powered by Google App Engine
This is Rietveld 408576698