Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2173523002: base: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=danakj@chromium.org BUG=554600 Committed: https://crrev.com/4058ac6be8672005d3113d49b945d9874e01f37c Cr-Commit-Position: refs/heads/master@{#406961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/files/file_path_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/java_heap_dump_provider_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_handle_test_dll.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-21 21:04:42 UTC) #1
danakj
LGTM
4 years, 5 months ago (2016-07-21 21:14:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173523002/1
4 years, 5 months ago (2016-07-21 21:17:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:06:01 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:07:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4058ac6be8672005d3113d49b945d9874e01f37c
Cr-Commit-Position: refs/heads/master@{#406961}

Powered by Google App Engine
This is Rietveld 408576698