third_party/WebKit/Source/core/svg/SVGURIReference.h - Issue 2173453002: Resolve URL/target reference at a single point in SVGUseElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 2173453002: Resolve URL/target reference at a single point in SVGUseElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing expected file Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/custom/use-external-dynamic-base-change.html ('K') | « third_party/WebKit/LayoutTests/svg/custom/use-external-dynamic-base-change-expected.html ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGURIReference.h

diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.h b/third_party/WebKit/Source/core/svg/SVGURIReference.h

index cc05a4f5284a97aa92dba8bc790a233f13cf99e3..97248ec0c9c9b00a9e88cd16a08ff514fdc8050e 100644

--- a/third_party/WebKit/Source/core/svg/SVGURIReference.h

+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.h

@@ -46,7 +46,7 @@ public:

KURL legacyHrefURL(const Document&) const;

static AtomicString fragmentIdentifierFromIRIString(const String&, const TreeScope&);

- static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0);

+ static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = nullptr);

static inline bool isExternalURIReference(const String& uri, const Document& document)

{