Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Issue 2173443003: Convert some component source sets to static library (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, ntp-dev+reviews_chromium.org, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, jam, petewil+watch_chromium.org, chili+watch_chromium.org, eroman, darin-cc_chromium.org, asvitkine+watch_chromium.org, gcasto+watchlist_chromium.org, wifiprefetch-reviews_google.com, mmenke, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some component source sets to static library This is hoping to achieve better build performance. BUG=627637 Committed: https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d Cr-Commit-Position: refs/heads/master@{#406996}

Patch Set 1 #

Patch Set 2 : no_policy #

Patch Set 3 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M components/nacl/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/common/BUILD.gn View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M components/nacl/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_interception/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/net_log/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/network_hints/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/network_hints/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/network_session_configurator/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/sync/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/content/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/logging/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/rlz/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/BUILD.gn View 11 chunks +11 lines, -11 lines 0 comments Download
M components/safe_json/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
no_policy
4 years, 5 months ago (2016-07-21 21:44:31 UTC) #1
brettw
4 years, 5 months ago (2016-07-21 21:44:46 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 22:08:14 UTC) #8
brettw
mac
4 years, 5 months ago (2016-07-21 22:26:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173443003/40001
4 years, 5 months ago (2016-07-21 22:27:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 23:48:53 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:50:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d
Cr-Commit-Position: refs/heads/master@{#406996}

Powered by Google App Engine
This is Rietveld 408576698