Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 2173443002: Fix a race condition in BrowsingDataRemover. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 std::unique_ptr<content::PluginDataRemover> plugin_data_remover_; 446 std::unique_ptr<content::PluginDataRemover> plugin_data_remover_;
447 base::WaitableEventWatcher watcher_; 447 base::WaitableEventWatcher watcher_;
448 448
449 // Used to deauthorize content licenses for Pepper Flash. 449 // Used to deauthorize content licenses for Pepper Flash.
450 std::unique_ptr<PepperFlashSettingsManager> pepper_flash_settings_manager_; 450 std::unique_ptr<PepperFlashSettingsManager> pepper_flash_settings_manager_;
451 #endif 451 #endif
452 452
453 uint32_t deauthorize_flash_content_licenses_request_id_ = 0; 453 uint32_t deauthorize_flash_content_licenses_request_id_ = 0;
454 // True if we're waiting for various data to be deleted. 454 // True if we're waiting for various data to be deleted.
455 // These may only be accessed from UI thread in order to avoid races! 455 // These may only be accessed from UI thread in order to avoid races!
456 bool waiting_for_synchronous_clear_operations_ = false;
456 bool waiting_for_clear_autofill_origin_urls_ = false; 457 bool waiting_for_clear_autofill_origin_urls_ = false;
457 bool waiting_for_clear_cache_ = false; 458 bool waiting_for_clear_cache_ = false;
458 bool waiting_for_clear_channel_ids_ = false; 459 bool waiting_for_clear_channel_ids_ = false;
459 bool waiting_for_clear_flash_content_licenses_ = false; 460 bool waiting_for_clear_flash_content_licenses_ = false;
460 // Non-zero if waiting for cookies to be cleared. 461 // Non-zero if waiting for cookies to be cleared.
461 int waiting_for_clear_cookies_count_ = 0; 462 int waiting_for_clear_cookies_count_ = 0;
462 bool waiting_for_clear_domain_reliability_monitor_ = false; 463 bool waiting_for_clear_domain_reliability_monitor_ = false;
463 bool waiting_for_clear_form_ = false; 464 bool waiting_for_clear_form_ = false;
464 bool waiting_for_clear_history_ = false; 465 bool waiting_for_clear_history_ = false;
465 bool waiting_for_clear_hostname_resolution_cache_ = false; 466 bool waiting_for_clear_hostname_resolution_cache_ = false;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 // not initialised, so the registry must be mocked out. 506 // not initialised, so the registry must be mocked out.
506 std::unique_ptr<WebappRegistry> webapp_registry_; 507 std::unique_ptr<WebappRegistry> webapp_registry_;
507 #endif 508 #endif
508 509
509 base::WeakPtrFactory<BrowsingDataRemover> weak_ptr_factory_; 510 base::WeakPtrFactory<BrowsingDataRemover> weak_ptr_factory_;
510 511
511 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover); 512 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
512 }; 513 };
513 514
514 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 515 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698