Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 217343002: Update code related to OOM errors in sanitizer builds. (Closed)

Created:
6 years, 9 months ago by earthdok
Modified:
6 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, willchan no longer on Chromium
Visibility:
Public.

Description

Update code related to OOM errors in sanitizer builds. Remove outdated comment and enable OOM tests under sanitizers. Also, document the fact that the newly introduced UncheckedMalloc()/UncheckedCalloc() don't work as intended in sanitizer builds. BUG=357732 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M base/process/memory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/process/memory_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/process/memory_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
earthdok
Please take a look.
6 years, 9 months ago (2014-03-28 19:31:32 UTC) #1
Nico
lgtm
6 years, 9 months ago (2014-03-28 19:34:52 UTC) #2
kbalazs
On 2014/03/28 19:34:52, Nico wrote: > lgtm Thanks for the cleanup!
6 years, 9 months ago (2014-03-28 20:06:08 UTC) #3
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 9 months ago (2014-03-28 22:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/217343002/1
6 years, 9 months ago (2014-03-28 22:49:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:28:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 00:28:06 UTC) #7
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 8 months ago (2014-03-29 10:02:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/217343002/1
6 years, 8 months ago (2014-03-29 10:03:07 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:30:41 UTC) #10
Message was sent while issue was closed.
Change committed as 260379

Powered by Google App Engine
This is Rietveld 408576698