Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2173423002: Don't throw during a disallow-heap-allocation scope (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't throw during a disallow-heap-allocation scope Exception throwing will allocate R=bmeurer@chromium.org BUG= Committed: https://crrev.com/a189839c53e443a06d58793462a3d53a421ef08f Cr-Commit-Position: refs/heads/master@{#37997}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/runtime/runtime-i18n.cc View 1 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-07-25 07:31:43 UTC) #1
Benedikt Meurer
LGTM.
4 years, 4 months ago (2016-07-25 08:02:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173423002/20001
4 years, 4 months ago (2016-07-25 08:07:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 08:09:05 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 08:35:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a189839c53e443a06d58793462a3d53a421ef08f
Cr-Commit-Position: refs/heads/master@{#37997}

Powered by Google App Engine
This is Rietveld 408576698