Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: src/objects.h

Issue 2173403002: Replace SmartArrayPointer<T> with unique_ptr<T[]> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 1ef9703be013bb7790d1c1f494bb60ad0ea52e53..383fd4c783595e6260d44a8445e136ae2af55208 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -6,6 +6,7 @@
#define V8_OBJECTS_H_
#include <iosfwd>
+#include <memory>
#include "src/assert-scope.h"
#include "src/bailout-reason.h"
@@ -9051,11 +9052,10 @@ class String: public Name {
// ROBUST_STRING_TRAVERSAL invokes behaviour that is robust This means it
// handles unexpected data without causing assert failures and it does not
// do any heap allocations. This is useful when printing stack traces.
- base::SmartArrayPointer<char> ToCString(AllowNullsFlag allow_nulls,
- RobustnessFlag robustness_flag,
- int offset, int length,
- int* length_output = 0);
- base::SmartArrayPointer<char> ToCString(
+ std::unique_ptr<char[]> ToCString(AllowNullsFlag allow_nulls,
+ RobustnessFlag robustness_flag, int offset,
+ int length, int* length_output = 0);
+ std::unique_ptr<char[]> ToCString(
AllowNullsFlag allow_nulls = DISALLOW_NULLS,
RobustnessFlag robustness_flag = FAST_STRING_TRAVERSAL,
int* length_output = 0);
« no previous file with comments | « src/messages.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698