src/frames.cc - Issue 2173403002: Replace SmartArrayPointer<T> with unique_ptr<T[]>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 2173403002: Replace SmartArrayPointer<T> with unique_ptr<T[]> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index f06a9c813bd134a5b7116d781c5f42c98cf2f37e..f0e18268425f0517916fadc26d98e0737a766bd0 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -4,6 +4,7 @@

#include "src/frames.h"

+#include <memory>

#include <sstream>

#include "src/ast/ast.h"

@@ -1005,7 +1006,7 @@ void JavaScriptFrame::PrintFunctionAndOffset(JSFunction* function, Code* code,

Object* script_name_raw = script->name();

if (script_name_raw->IsString()) {

String* script_name = String::cast(script->name());

- base::SmartArrayPointer<char> c_script_name =

+ std::unique_ptr<char[]> c_script_name =

script_name->ToCString(DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL);

PrintF(file, " at %s:%d", c_script_name.get(), line);

} else {

« no previous file with comments | « src/disassembler.cc ('k') | src/gdb-jit.cc » ('j') | no next file with comments »