Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/disassembler.cc

Issue 2173403002: Replace SmartArrayPointer<T> with unique_ptr<T[]> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: even less redness Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler/graph-visualizer.cc ('K') | « src/deoptimizer.cc ('k') | src/frames.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/disassembler.cc
diff --git a/src/disassembler.cc b/src/disassembler.cc
index e32904df5cb2073e210463d860858bf5a74b7d6d..b43a4df991f95f47bd74f0ae9ca82d1aa45e64d5 100644
--- a/src/disassembler.cc
+++ b/src/disassembler.cc
@@ -4,6 +4,8 @@
#include "src/disassembler.h"
+#include <memory>
+
#include "src/code-stubs.h"
#include "src/codegen.h"
#include "src/debug/debug.h"
@@ -185,7 +187,7 @@ static int DecodeIt(Isolate* isolate, std::ostream* os,
HeapStringAllocator allocator;
StringStream accumulator(&allocator);
relocinfo.target_object()->ShortPrint(&accumulator);
- base::SmartArrayPointer<const char> obj_name = accumulator.ToCString();
+ std::unique_ptr<const char[]> obj_name = accumulator.ToCString();
Igor Sheludko 2016/07/25 08:56:44 Same here.
jochen (gone - plz use gerrit) 2016/07/25 09:14:48 done
out.AddFormatted(" ;; object: %s", obj_name.get());
} else if (rmode == RelocInfo::EXTERNAL_REFERENCE) {
const char* reference_name = ref_encoder.NameOfAddress(
« src/compiler/graph-visualizer.cc ('K') | « src/deoptimizer.cc ('k') | src/frames.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698