Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: test/cctest/test-func-name-inference.cc

Issue 2173403002: Replace SmartArrayPointer<T> with unique_ptr<T[]> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include <memory>
28 29
29 #include "src/v8.h" 30 #include "src/v8.h"
30 31
31 #include "src/api.h" 32 #include "src/api.h"
32 #include "src/debug/debug.h" 33 #include "src/debug/debug.h"
33 #include "src/string-search.h" 34 #include "src/string-search.h"
34 #include "test/cctest/cctest.h" 35 #include "test/cctest/cctest.h"
35 36
36 37
37 using ::v8::base::SmartArrayPointer;
38 using ::v8::internal::CStrVector; 38 using ::v8::internal::CStrVector;
39 using ::v8::internal::Factory; 39 using ::v8::internal::Factory;
40 using ::v8::internal::Handle; 40 using ::v8::internal::Handle;
41 using ::v8::internal::Heap; 41 using ::v8::internal::Heap;
42 using ::v8::internal::Isolate; 42 using ::v8::internal::Isolate;
43 using ::v8::internal::JSFunction; 43 using ::v8::internal::JSFunction;
44 using ::v8::internal::Object; 44 using ::v8::internal::Object;
45 using ::v8::internal::Runtime; 45 using ::v8::internal::Runtime;
46 using ::v8::internal::Script; 46 using ::v8::internal::Script;
47 using ::v8::internal::SharedFunctionInfo; 47 using ::v8::internal::SharedFunctionInfo;
(...skipping 30 matching lines...) Expand all
78 func_pos_str, 0); 78 func_pos_str, 0);
79 } 79 }
80 CHECK_NE(0, func_pos); 80 CHECK_NE(0, func_pos);
81 81
82 // Obtain SharedFunctionInfo for the function. 82 // Obtain SharedFunctionInfo for the function.
83 Handle<SharedFunctionInfo> shared_func_info = 83 Handle<SharedFunctionInfo> shared_func_info =
84 Handle<SharedFunctionInfo>::cast( 84 Handle<SharedFunctionInfo>::cast(
85 isolate->debug()->FindSharedFunctionInfoInScript(i_script, func_pos)); 85 isolate->debug()->FindSharedFunctionInfoInScript(i_script, func_pos));
86 86
87 // Verify inferred function name. 87 // Verify inferred function name.
88 SmartArrayPointer<char> inferred_name = 88 std::unique_ptr<char[]> inferred_name =
89 shared_func_info->inferred_name()->ToCString(); 89 shared_func_info->inferred_name()->ToCString();
90 i::PrintF("expected: %s, found: %s\n", ref_inferred_name, 90 i::PrintF("expected: %s, found: %s\n", ref_inferred_name,
91 inferred_name.get()); 91 inferred_name.get());
92 CHECK_EQ(0, strcmp(ref_inferred_name, inferred_name.get())); 92 CHECK_EQ(0, strcmp(ref_inferred_name, inferred_name.get()));
93 } 93 }
94 94
95 95
96 static v8::Local<v8::Script> Compile(v8::Isolate* isolate, const char* src) { 96 static v8::Local<v8::Script> Compile(v8::Isolate* isolate, const char* src) {
97 return v8::Script::Compile( 97 return v8::Script::Compile(
98 isolate->GetCurrentContext(), 98 isolate->GetCurrentContext(),
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 " };\n" 532 " };\n"
533 " var foo = 10;\n" 533 " var foo = 10;\n"
534 " function f() {\n" 534 " function f() {\n"
535 " return wrapCode();\n" 535 " return wrapCode();\n"
536 " }\n" 536 " }\n"
537 " this.ref = f;\n" 537 " this.ref = f;\n"
538 "})()"); 538 "})()");
539 script->Run(CcTest::isolate()->GetCurrentContext()).ToLocalChecked(); 539 script->Run(CcTest::isolate()->GetCurrentContext()).ToLocalChecked();
540 CheckFunctionName(script, "return 2012", ""); 540 CheckFunctionName(script, "return 2012", "");
541 } 541 }
OLDNEW
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698