Replace SmartArrayPointer<T> with unique_ptr<T[]>

src/wasm/decoder.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_WASM_DECODER_H_
 #define V8_WASM_DECODER_H_
 
+#include <memory>
+
 #include "src/base/compiler-specific.h"
 #include "src/base/smart-pointers.h"
 #include "src/flags.h"
 #include "src/signature.h"
 #include "src/utils.h"
 #include "src/wasm/wasm-result.h"
 #include "src/zone-containers.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 222 matching lines @@
       if (FLAG_wasm_break_on_decoder_error) {
         base::OS::DebugBreak();
       }
 #endif
       const int kMaxErrorMsg = 256;
       char* buffer = new char[kMaxErrorMsg];
       va_list arguments;
       va_start(arguments, format);
       base::OS::VSNPrintF(buffer, kMaxErrorMsg - 1, format, arguments);
       va_end(arguments);
-      error_msg_.Reset(buffer);
+      error_msg_.reset(buffer);
       error_pc_ = pc;
       error_pt_ = pt;
       onFirstError();
     }
   }
 
   // Behavior triggered on first error, overridden in subclasses.
   virtual void onFirstError() {}
 
   // Debugging helper to print bytes up to the end.
@@ skipping 12 matching lines @@
   template <typename T>
   Result<T> toResult(T val) {
     Result<T> result;
     if (error_pc_) {
       TRACE("Result error: %s\n", error_msg_.get());
       result.error_code = kError;
       result.start = start_;
       result.error_pc = error_pc_;
       result.error_pt = error_pt_;
       // transfer ownership of the error to the result.
-      result.error_msg.Reset(error_msg_.Detach());
+      result.error_msg.reset(error_msg_.release());
     } else {
       result.error_code = kSuccess;
     }
     result.val = std::move(val);
     return result;
   }
 
   // Resets the boundaries of this decoder.
   void Reset(const byte* start, const byte* end) {
     start_ = start;
     pc_ = start;
     limit_ = end;
     end_ = end;
     error_pc_ = nullptr;
     error_pt_ = nullptr;
-    error_msg_.Reset(nullptr);
+    error_msg_.reset(nullptr);

[Igor Sheludko, 2016/07/25 08:56:44]

Just .reset()

[jochen (gone - plz use gerrit), 2016/07/25 09:14:48]

done

   }
 
   bool ok() const { return error_pc_ == nullptr; }
-  bool failed() const { return !error_msg_.is_empty(); }
+  bool failed() const { return !!error_msg_; }
   bool more() const { return pc_ < limit_; }
 
   const byte* start() { return start_; }
   const byte* pc() { return pc_; }
   uint32_t pc_offset() { return static_cast<uint32_t>(pc_ - start_); }
 
  protected:
   const byte* start_;
   const byte* pc_;
   const byte* limit_;
   const byte* end_;
   const byte* error_pc_;
   const byte* error_pt_;
-  base::SmartArrayPointer<char> error_msg_;
+  std::unique_ptr<char[]> error_msg_;
 
  private:
   template <typename IntType, bool is_signed>
   IntType checked_read_leb(const byte* base, unsigned offset, unsigned* length,
                            const char* msg) {
     if (!check(base, offset, 1, msg)) {
       *length = 0;
       return 0;
     }
 
@@ skipping 42 matching lines @@
     return result;
   }
 };
 
 #undef TRACE
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_WASM_DECODER_H_