Replace SmartArrayPointer<T> with unique_ptr<T[]>

src/compiler/graph-visualizer.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-visualizer.h"
 
+#include <memory>
 #include <sstream>
 #include <string>
 
 #include "src/code-stubs.h"
 #include "src/compiler/all-nodes.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/node.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/compiler/operator-properties.h"
 #include "src/compiler/register-allocator.h"
 #include "src/compiler/schedule.h"
 #include "src/compiler/scheduler.h"
 #include "src/interpreter/bytecodes.h"
 #include "src/ostreams.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
-base::SmartArrayPointer<const char> GetVisualizerLogFileName(
-    CompilationInfo* info, const char* phase, const char* suffix) {
+std::unique_ptr<const char[]> GetVisualizerLogFileName(CompilationInfo* info,
+                                                       const char* phase,
+                                                       const char* suffix) {
   EmbeddedVector<char, 256> filename(0);
-  base::SmartArrayPointer<char> debug_name = info->GetDebugName();
+  std::unique_ptr<char[]> debug_name = info->GetDebugName();
   if (strlen(debug_name.get()) > 0) {
     SNPrintF(filename, "turbo-%s", debug_name.get());
   } else if (info->has_shared_info()) {
     SNPrintF(filename, "turbo-%p", static_cast<void*>(info));
   } else {
     SNPrintF(filename, "turbo-none-%s", phase);
   }
   EmbeddedVector<char, 256> source_file(0);
   bool source_available = false;
   if (FLAG_trace_file_names && info->parse_info()) {
@@ skipping 20 matching lines @@
     SNPrintF(full_filename, "%s_%s.%s", filename.start(), source_file.start(),
              suffix);
   } else {
     SNPrintF(full_filename, "%s_%s-%s.%s", filename.start(),
              source_file.start(), phase, suffix);
   }
 
   char* buffer = new char[full_filename.length() + 1];
   memcpy(buffer, full_filename.start(), full_filename.length());
   buffer[full_filename.length()] = '\0';
-  return base::SmartArrayPointer<const char>(buffer);
+  return std::unique_ptr<const char[]>(const_cast<const char*>(buffer));

[Igor Sheludko, 2016/07/25 08:56:44]

I think const_cast<> is intended to be used to remove constness/volatileness. It
should be possible to pass char* without any casts to where const char* is
expected.

And since we always create a new buffer on every call there's probably no need
to return const array. Maybe it makes sense to return std::unique_ptr<char[]>
from here as we do in all other places.

[jochen (gone - plz use gerrit), 2016/07/25 09:14:48]

done

 }
 
 
 static int SafeId(Node* node) { return node == nullptr ? -1 : node->id(); }
 static const char* SafeMnemonic(Node* node) {
   return node == nullptr ? "null" : node->op()->mnemonic();
 }
 
 #define DEAD_COLOR "#999999"
 
@@ skipping 238 matching lines @@
 
 
 void GraphC1Visualizer::PrintIntProperty(const char* name, int value) {
   PrintIndent();
   os_ << name << " " << value << "\n";
 }
 
 
 void GraphC1Visualizer::PrintCompilation(const CompilationInfo* info) {
   Tag tag(this, "compilation");
-  base::SmartArrayPointer<char> name = info->GetDebugName();
+  std::unique_ptr<char[]> name = info->GetDebugName();
   if (info->IsOptimizing()) {
     PrintStringProperty("name", name.get());
     PrintIndent();
     os_ << "method \"" << name.get() << ":" << info->optimization_id()
         << "\"\n";
   } else {
     PrintStringProperty("name", name.get());
     PrintStringProperty("method", "stub");
   }
   PrintLongProperty("date",
@@ skipping 349 matching lines @@
         os << "]";
       }
       os << std::endl;
     }
   }
   return os;
 }
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8