Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2173383002: [Merge M-53] [Payments] Use the correct index when checking addresses (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M-53] [Payments] Use the correct index when checking addresses We have an off-by-one error now that the mOptionLayout can have multiple children in it above the actual options. * Use the correct index when indexing into the options layout. * Add a test that checks for the crash and additionally checks that the "merchant doesn't accept address" string is correctly displayed. * Plumbs a new callback that indicates that the client has finished checking the selection. BUG=630348 Review-Url: https://codereview.chromium.org/2170603006 Cr-Commit-Position: refs/heads/master@{#407197} (cherry picked from commit 80155b30015fca0ea8774117ee2a9b8d0d8da91d) Committed: https://chromium.googlesource.com/chromium/src/+/aeb73e31bf78992a0303c8325c4f1e3dcb26dc1b

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 5 months ago (2016-07-25 01:21:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aeb73e31bf78992a0303c8325c4f1e3dcb26dc1b.

Powered by Google App Engine
This is Rietveld 408576698